Thread: My most amazing error yet! [complicated]

>> Are you even allowed to just take the address of the first element of a vector, and assume that everything is contiguous from that point?

Yes, the code you quoted is correct. The vector version has the advantage of automatic memory management as well, which is why it is preferred over your solution.

Code:

>	WNDCLASSEX wcex;		
>	ZeroMemory(&wcex, sizeof(wcex));
>	wcex.cbSize	= sizeof(WNDCLASSEX);	
>	wcex.style	= CS_HREDRAW | CS_VREDRAW;
>	wcex.lpfnWndProc = (WNDPROC) WndProc;
>	wcex.hInstance= hInstance;
>	wcex.hCursor= LoadCursor(NULL, IDC_ARROW);
>	wcex.lpszClassName= name;

It looks like you never called RegisterClassEx to register the window class.

>Pedantically, even reading an uninitialised value may cause a trap for anything which isn't a char.
Wow, I did not know that. I knew it was true for unitialized pointers, but not other types.

If your "test" code is no more than a few hundred lines, then ZIP it up in an attachment, and include small examples of the .ini and .raw files.

Simply posting random snippets, with random bits of key information removed by your over zealous editing is just going to keep throwing up "you missed...." responses.

Basically, do a "build->Clean" then ZIP the project.

> fread(fileText, 1, count, theFile);
I see from the rest of your code that you're reading a text file.

Some points.
1. You don't look at the return result of fread
2. You don't put a \0 at the end to make it a string
3. You don't allocate space for this \0

So perhaps

Code:

    while( fread(temp, 1, 1,theFile) == 1 ) 
    {
      count++;
    }
    
    filetext = new char[count+1];
    rewind(theFile);              
    int n = fread(filetext, 1, count, theFile);
    if ( n > 0 ) filetext[n] = '\0'

> delete(filetext);
1. You do it in TWO places, so you're likely to end up deleting it twice (which is worse than not deleting it at all).
2. Since you new'ed an array, you need to delete an array.
delete [ ] filetext;

If you want to delete it in closeFile(), at least do this so the dtor is harmless
delete [ ] filetext;
filetext = 0;



And man, your comments are indented SO far off to the right as to be totally meaningless.

Finally, take out all those while() loops which are your 'fix' for the problem. Whatever the answer will be, you can be sure that the answer won't be using them.

Originally Posted by Salem

> fread(fileText, 1, count, theFile);
I see from the rest of your code that you're reading a text file.

Some points.
1. You don't look at the return result of fread
2. You don't put a \0 at the end to make it a string
3. You don't allocate space for this \0

So perhaps

Code:

    while( fread(temp, 1, 1,theFile) == 1 ) 
    {
      count++;
    }
    
    filetext = new char[count+1];
    rewind(theFile);              
    int n = fread(filetext, 1, count, theFile);
    if ( n > 0 ) filetext[n] = '\0'

Thanks, I'm trying that out I

EDIT: I don't actually know if it's working better or not because I'm still getting the errors, but it definitely looks cleaner than what I had before.

Originally Posted by Salem

> delete(filetext);
1. You do it in TWO places, so you're likely to end up deleting it twice (which is worse than not deleting it at all).
2. Since you new'ed an array, you need to delete an array.
delete [ ] filetext;

If you want to delete it in closeFile(), at least do this so the dtor is harmless
delete [ ] filetext;
filetext = 0;

Thanks for pointing that out, I've fixed that.

Originally Posted by Salem

And man, your comments are indented SO far off to the right as to be totally meaningless.

Sorry bout that, my computer has a widescreen resolution so they looked fine on it.

Finally, take out all those while() loops which are your 'fix' for the problem. Whatever the answer will be, you can be sure that the answer won't be using them.

[/QUOTE]

I know that they're not an elegant solution, but they were working when the only problem was the code not initialising variables, but there's too much weird stuff going on, so they've been removed. (I believe they were commented out in the version that I uploaded?)


I've tested it after trying all those things, and I'm still getting the same errors. Did you see anything in it that seemed blatantly wrong at this point? I've been going through it for three or four weeks now and a fresh pair of eyes is always useful.

Upload your latest, and I'll have another look tonight.

I don't have the patience to crawl through your chaotic mix of C and C++ comments.

It makes no sense to me where the real code begins.

Randomness prevails.

You're still not deleting the string properly.

> although nothing changed when I commented most of it out.
Except a lot of class member variables which were being initialised are now garbage.

For a start, I would make each CONSTRUCTOR actually do something useful, like make sure every variable is initialised, and every pointer is NULL.
At least then you might stand a chance of getting consistency.

About the only thing I can come up with is this:
>game *Glitch = new game(); //lookit that! Glitch is a game now.

You do this outside of any function, and I don't know the ramifications. It seems to compile, but just for fun, I would try moving the new part into WinMain:

Code:

//Keep global
game *Glitch;

//Add to WinMain
   Glitch = new game();